Skip to content

Conversation

@Shizoqua
Copy link

Summary

This PR fixes an interface/plumbing gap in historical retrieval by explicitly passing the requested On-Demand Feature Views (ODFVs) from FeatureStore.get_historical_features() into the provider’s get_historical_features() implementation.

What changed

  • Updated Provider.get_historical_features(...) signature to include:
    • on_demand_feature_views: List[OnDemandFeatureView]
  • Updated FeatureStore.get_historical_features() to pass the computed on_demand_feature_views list into the provider call.
  • Updated PassthroughProvider.get_historical_features() to accept the new argument (ignored for passthrough delegation).
  • Updated the test FooProvider implementation to match the new provider interface.
  • Added a unit test that asserts the provider receives the expected ODFVs list:
    • sdk/python/tests/unit/test_feature_store_passes_odfvs_to_provider.py

Why

Providers may need the explicit set of requested ODFVs to correctly handle or route historical retrieval logic. Previously, only the combined feature_views list was passed, which made it awkward/impossible for providers to distinguish which ODFVs were requested.

Testing

  • Added unit test test_feature_store_passes_on_demand_feature_views_to_provider.

@Shizoqua Shizoqua requested a review from a team as a code owner December 31, 2025 00:15
@Shizoqua Shizoqua force-pushed the feat/pass-odfvs-to-provider branch from e63b40b to b2d82b6 Compare December 31, 2025 00:18
@Shizoqua Shizoqua changed the title Feat: Pass requested On-Demand Feature Views to Provider get_historical_features Feat: Pass requested On-Demand Feature Views Dec 31, 2025
@Shizoqua Shizoqua changed the title Feat: Pass requested On-Demand Feature Views Feat: Pass requested On-Demand Feature Views from FeatureStore.get_historical_features() Dec 31, 2025
@Shizoqua Shizoqua changed the title Feat: Pass requested On-Demand Feature Views from FeatureStore.get_historical_features() Feat: Pass requested On-Demand Feature Views to Provider get_historical_features Dec 31, 2025
@Shizoqua Shizoqua changed the title Feat: Pass requested On-Demand Feature Views to Provider get_historical_features feat: Pass requested On-Demand Feature Views to Provider get_historical_features Jan 1, 2026
@Shizoqua
Copy link
Author

Shizoqua commented Jan 1, 2026

Good day @franciscojavierarceo
I would appreciate it if my PR is looked at and reviewed if there is any comment you'd want to give in relations to the PR would be highly appreciated.

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>
Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>
Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>
Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>
@Shizoqua Shizoqua force-pushed the feat/pass-odfvs-to-provider branch from 0458b97 to 1501fd4 Compare January 12, 2026 19:34
@Shizoqua
Copy link
Author

Good day @franciscojavierarceo
I would appreciate it if my PR is looked at and reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants