fix: Denial by default to all resources when no permissions set #5663
+73
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyejare <jyejare@redhat.com> filter only for named patterns No matching permissions are handled
59af5bb to
1d1bfb0
Compare
Signed-off-by: jyejare <jyejare@redhat.com>
ntkathole
reviewed
Dec 15, 2025
| if not resource_type_permissions: | ||
| # No permissions exist for this resource type - should raise error | ||
| message = f"No permissions defined to manage {actions} on {type(resource)}/{resource.name}." | ||
| logger.exception(f"**PERMISSION NOT GRANTED**: {message}") |
Member
There was a problem hiding this comment.
should this be logger.error() ?
Collaborator
Author
There was a problem hiding this comment.
Yeah thats error with exception :)
| if not filter_only: | ||
| raise FeastPermissionError("No permissions defined - access denied") | ||
| return [] | ||
| raise FeastPermissionError( |
Member
There was a problem hiding this comment.
wait, am i correct in understanding that if no permissions are enabled we'll raise the permission error for everyone? is this forcing the functionality to everyone then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We observed Inconsistent permission response behavior across Feature Store API routes.
Which issue(s) this PR fixes:
Inconsistent permission response behavior across Feature Store API routes. RHOAIENG-35929
Misc