Skip to content

feat: Added global search api and necessary unit tests #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 18 commits into from
Aug 14, 2025
Merged

feat: Added global search api and necessary unit tests #5532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3a4d2a9
feat: Added global search api and necessary unit tests
aniketpalu Jul 22, 2025
006ef69
Minor refactoring
aniketpalu Jul 22, 2025
3b44f55
Addressed comments, create re-usable function to get all resources, r…
aniketpalu Jul 28, 2025
808d126
Rebased due to updated upstream
aniketpalu Jul 30, 2025
3c71804
Re-usable & modular dependency functions, removal of unnecessary fiel…
aniketpalu Jul 30, 2025
cfa32b1
Minor refactoring & optimzations
aniketpalu Jul 30, 2025
35db91d
Minor reformatting, optimized unit tests to do more comprehensive tests
aniketpalu Jul 31, 2025
8be2e6f
Fixed minor linting error
aniketpalu Jul 31, 2025
24cd526
Merge branch 'feast-dev:master' into feature/global-search
aniketpalu Aug 7, 2025
b353317
Optimized Code, better error handling, created reusable functions and…
aniketpalu Aug 7, 2025
0765720
Minor formatting & type lints related changes
aniketpalu Aug 7, 2025
3dda05a
Merge branch 'feast-dev:master' into feature/global-search
aniketpalu Aug 10, 2025
33a5292
Added exact similarity score in response, updated docs
aniketpalu Aug 11, 2025
c5a6791
Minor reformatting & fixed lint error
aniketpalu Aug 11, 2025
81204d9
Conflicts resolved
aniketpalu Aug 11, 2025
20c34e8
Added onDemandFeatureView test cases, minor function naming changes a…
aniketpalu Aug 13, 2025
9ab68db
Merge remote-tracking branch 'origin/master' into feature/global-search
aniketpalu Aug 13, 2025
214e13c
Minor code change after rebase
aniketpalu Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor formatting & type lints related changes 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu
aniketpalu committed Aug 7, 2025
commit 07657202a70f3a925303ffb5adb47176611ec33c
22 changes: 10 additions & 12 deletions sdk/python/feast/api/registry/rest/lineage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""REST API endpoints for registry lineage and relationships."""

from typing import Optional
import logging
from typing import Optional

from fastapi import APIRouter, Depends, HTTPException, Query

Expand Down Expand Up @@ -156,7 +156,9 @@ def get_complete_registry_data(
sorting_params=sorting_params,
)
if errors and not project_resources:
logger.error(f"Error getting project resources for project {project}: {errors}")
logger.error(
f"Error getting project resources for project {project}: {errors}"
)
return {
"project": project,
"objects": {},
Expand All @@ -178,15 +180,9 @@ def get_complete_registry_data(
"pagination": {
# Get pagination metadata from project_resources if available, otherwise use empty dicts
"entities": pagination.get("entities", {}),
"dataSources": pagination.get(
"dataSources", {}
),
"featureViews": pagination.get(
"featureViews", {}
),
"featureServices": pagination.get(
"featureServices", {}
),
"dataSources": pagination.get("dataSources", {}),
"featureViews": pagination.get("featureViews", {}),
"featureServices": pagination.get("featureServices", {}),
"features": pagination.get("features", {}),
"relationships": lineage_response.get("relationshipsPagination", {}),
"indirectRelationships": lineage_response.get(
Expand Down Expand Up @@ -256,7 +252,9 @@ def get_complete_registry_data_all(
)

if errors and not project_resources:
logger.error(f"Error getting project resources for project {project_name}: {errors}")
logger.error(
f"Error getting project resources for project {project_name}: {errors}"
)
continue

# Add project field to each object
Expand Down
4 changes: 1 addition & 3 deletions sdk/python/feast/api/registry/rest/projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
from fastapi import APIRouter, Depends, Query

from feast.api.registry.rest.rest_utils import (
create_grpc_pagination_params,
create_grpc_sorting_params,
get_pagination_params,
get_sorting_params,
grpc_call,
Expand Down Expand Up @@ -42,7 +40,7 @@ def list_projects(
)
except Exception as e:
return {"error": str(e)}

if err_msg:
return {"error": err_msg}

Expand Down
Loading
Loading