Skip to content

feat: Add interfaces for batch materialization engine #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Jul 6, 2022
Merged

feat: Add interfaces for batch materialization engine #2901

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6cc7e75
feat: Add scaffolding for batch materialization engine
achals Jul 1, 2022
1656436
fix tests
achals Jul 5, 2022
c16734b
fix tests
achals Jul 5, 2022
ceedbab
a little better
achals Jul 5, 2022
37fa081
a little better
achals Jul 5, 2022
795e65a
docs
achals Jul 5, 2022
5833556
more api updates'
achals Jul 5, 2022
5d1af33
fix typos
achals Jul 6, 2022
ff680a9
make engine importable
achals Jul 6, 2022
11b6da0
style stuff
achals Jul 6, 2022
2e9e7a8
style stuff
achals Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typos 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Jul 6, 2022
commit 5d1af3396884a250bce1b21abff9f506638e9971
2 changes: 1 addition & 1 deletion sdk/python/feast/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def _convert_arrow_to_proto(
feature_view: "FeatureView",
join_keys: Dict[str, ValueType],
) -> List[Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]]:
# Avoid ChunkedArrays which guarentees `zero_copy_only` availiable.
# Avoid ChunkedArrays which guarantees `zero_copy_only` available.
if isinstance(table, pyarrow.Table):
table = table.to_batches()[0]

Expand Down