Skip to content

Conversation

@kushalkolar
Copy link
Member

closes #912

@almarklein I think this will fix it right?

@kushalkolar kushalkolar requested a review from clewis7 as a code owner October 11, 2025 00:32
@github-actions
Copy link

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/remove-existing-screenshots

@kushalkolar
Copy link
Member Author

yup this works! Now there are no no-imgui screenshots in the non-imgui regeneration artifact 😆 . And only the standard with imgui screenshots in the imgui regeneration artifact.

@clewis7 should be gtg, tests will not pass because a few PRs have to be merged/have been merged that change most screenshots so I'll do it all at once.

@kushalkolar
Copy link
Member Author

@clewis7 let's merge this first and then I can rebase #914 on main so it has the nice cleaner screenshots artifact, and I will replace the screenshots on that PR.

@almarklein
Copy link
Collaborator

Thanks for solving this 😃

@clewis7 clewis7 merged commit 31f0f03 into main Oct 17, 2025
4 of 52 checks passed
@clewis7 clewis7 deleted the remove-existing-screenshots branch October 17, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

screenshot artifacts

4 participants