thinner lines for Linear and LinearRegion selectors, fully transparent thick outer lines as hitboxes #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t thick outer line serves as a hitbox
almarklein
reviewed
Sep 29, 2025
almarklein
reviewed
Sep 29, 2025
almarklein
reviewed
Sep 29, 2025
Member
Author
|
@almarklein do you think this is overall the right approach here after your alpha refactor? |
Co-authored-by: Almar Klein <almar@almarklein.org>
…lib/fastplotlib into better-selector-handles
This was referenced Oct 1, 2025
Merged
clewis7
previously approved these changes
Oct 3, 2025
Member
|
docs are failing? and some of the tests should be passing no? |
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/better-selector-handles |
Member
Author
|
all non-release tests passing |
Member
Author
|
Merge conflict in the lfs files O_O. I'm going to copy this over to a new PR before we discover novel ways to get git lfs smudge errors, @FlynnOConnell |
Merged
Member
Author
|
superseeded by #914, I don't want to risk a git lfs error again with a merge conflict in an lfs pointer (how tf does that even happen?!? 😨 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the alpha refactor by @almarklein this is finally possible! I think this looks much better, the width of the outer transparent line is a kwarg
hitbox_widthlinear-2025-09-29_03.30.43.mp4
linear_region-2025-09-29_03.38.24.mp4