Skip to content

Conversation

@FlynnOConnell
Copy link
Collaborator

Dont think we need ndim for image widgets. Was just using some suite2p binary files that didn't pass _is_array_like() because it didn't have ndim. Will test if you dont think its stupid

@github-actions
Copy link

github-actions bot commented Apr 16, 2025

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/no-ndim-for-iw

@FlynnOConnell
Copy link
Collaborator Author

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/no-ndim-for-iw

stealing this

@kushalkolar
Copy link
Member

I think this would also have to be changed in __init__ ??

@FlynnOConnell
Copy link
Collaborator Author

I think this would also have to be changed in __init__ ??

@kushalkolar Sorry I completely missed this comment! The changes I made are in init, can you elaborate?

@kushalkolar
Copy link
Member

I think this would also have to be changed in __init__ ??

@kushalkolar Sorry I completely missed this comment! The changes I made are in init, can you elaborate?

It's in set_data()?

@FlynnOConnell
Copy link
Collaborator Author

@kushalkolar fixed this up

@kushalkolar
Copy link
Member

closing in favor of #868

@FlynnOConnell FlynnOConnell deleted the no-ndim-for-iw branch November 20, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants