add macos-latest to CI matrix #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/add-mac-ci |
Member
Author
|
mac test failing because there is a slight diff for the lines-data test, will increase tolerance to 0.1 for nb tests, still lower than the default tolerance from the original pygfx code which was 0.2 .
|
Closed
Member
Author
|
ok so basically everything that isn't pygfx-latest is passing! 🥳 |
Member
Author
|
This mean we'll have over 50 tests with all the variants, but once pygfx becomes more stable it'll go down by half which seems normal for projects of this scope (I looked at matplotlib etc.) |
clewis7
approved these changes
Jan 25, 2025
Member
Author
|
@almarklein thought you might be interested to know that tests now work with the github mac runners 😄 |
Collaborator
|
O, that's really cool! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's see if this works