Skip to content

Conversation

@kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Apr 7, 2024

closes #425

  • controllers kwarg to Gridplot to manually pass pygfx.Controller instance(s), all other controller kwargs are ignored if this is passed
  • add @cameras and @controllers properties to Gridplot
  • tests the various cameras and controllers kwargs, and changing cameras and controllers after gridplot creation

@kushalkolar kushalkolar marked this pull request as ready for review April 7, 2024 09:57
@kushalkolar kushalkolar requested a review from clewis7 as a code owner April 7, 2024 09:57
@kushalkolar kushalkolar merged commit 418a73b into main Apr 7, 2024
@kushalkolar kushalkolar deleted the gp-controllers-kwarg branch April 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directly pass Controller instances to GridPlot

3 participants