Add black to setup in optional feature set for tests #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Might also be time to add a GitHub action to check for black
…On Mon, Mar 18, 2024, 00:06 Eric Thomson ***@***.***> wrote:
Addresses #435 <#435>.
Also changes .gitignore, adding VS Code config file.
------------------------------
You can view, comment on, or merge this pull request online at:
#436
Commit Summary
- ae72be9
<ae72be9>
ignore vscode config dir
- c60f247
<c60f247>
added black to optional tests install
File Changes
(2 files <https://github.com/fastplotlib/fastplotlib/pull/436/files>)
- *M* .gitignore
<https://github.com/fastplotlib/fastplotlib/pull/436/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>
(3)
- *M* setup.py
<https://github.com/fastplotlib/fastplotlib/pull/436/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7>
(1)
Patch Links:
- https://github.com/fastplotlib/fastplotlib/pull/436.patch
- https://github.com/fastplotlib/fastplotlib/pull/436.diff
—
Reply to this email directly, view it on GitHub
<#436>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHXXRCW4STSJ44ZPRLQQD3YYZR6DAVCNFSM6AAAAABE22QLQKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TCMJYGM2DSNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
kushalkolar
requested changes
Mar 18, 2024
Contributor
Author
|
At point now where not sure if |
Member
|
ok so we need to black our nbs too 😆 |
kushalkolar
requested changes
Mar 20, 2024
Member
kushalkolar
left a comment
There was a problem hiding this comment.
one last thing and should be good to go! :D
kushalkolar
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435.
Also changes
.gitignore, adding VS Code config file.