Skip to content

Conversation

@kushalkolar
Copy link
Member

closes #352

@kushalkolar kushalkolar requested a review from clewis7 November 1, 2023 08:38
@kushalkolar
Copy link
Member Author

Really bizarre failure only on python3.10 in the nb tests O_O. Will just rerun the test, maybe github actions is being weird.

=================================== FAILURES ===================================
_ /home/runner/work/fastplotlib/fastplotlib/examples/notebooks/lines_cmap.ipynb _
---------------------------------------------------------------------------
# for testing, ignore
notebook_finished()
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[19], line 2
      1 # for testing, ignore
----> 2 notebook_finished()

File ~/work/fastplotlib/fastplotlib/examples/notebooks/nb_test_utils.py:85, in notebook_finished()
     83 def notebook_finished():
     84     if len(FAILURES) > 0:
---> 85         raise AssertionError(
     86             f"Failures for plots:\n{FAILURES}"
     87         )

AssertionError: Failures for plots:
['lines-cmap-white', 'lines-cmap-jet', 'lines-cmap-jet-values', 'lines-cmap-jet-values-cosine', 'lines-cmap-viridis', 'lines-cmap-viridis-values', 'lines-cmap-tab-10']
__ /home/runner/work/fastplotlib/fastplotlib/examples/notebooks/simple.ipynb ___
---------------------------------------------------------------------------
# for testing, ignore
notebook_finished()
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[64], line 2
      1 # for testing, ignore
----> 2 notebook_finished()

File ~/work/fastplotlib/fastplotlib/examples/notebooks/nb_test_utils.py:85, in notebook_finished()
     83 def notebook_finished():
     84     if len(FAILURES) > 0:
---> 85         raise AssertionError(
     86             f"Failures for plots:\n{FAILURES}"
     87         )

AssertionError: Failures for plots:
['camera', 'astronaut', 'astronaut_RGB', 'lines', 'lines-colors', 'lines-data', 'lines-underlay', 'lines-3d']
=========================== short test summary info ============================
FAILED examples/notebooks/lines_cmap.ipynb:: - ['lines-cmap-white', 'lines-cmap-jet', 'lines-cmap-jet-values', 'lines-cmap-jet-values-cosine', 'lines-cmap-viridis', 'lines-cmap-viridis-values', 'lines-cmap-tab-10']
FAILED examples/notebooks/simple.ipynb:: - ['camera', 'astronaut', 'astronaut_RGB', 'lines', 'lines-colors', 'lines-data', 'lines-underlay', 'lines-3d']
======================== 2 failed, 10 passed in 47.03s =========================
Error: Process completed with exit code 1.

@kushalkolar kushalkolar merged commit 430f513 into main Nov 2, 2023
@kushalkolar kushalkolar deleted the fix-min-max-norm branch November 4, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

weird floating point error in setter for cmap_values

2 participants