refactor text graphic #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
kushalkolar
requested changes
Oct 25, 2023
Member
|
can you run black on only the textgraphic, else this will cause merge conflicts with every other WIP PR. we should look into ruff longterm |
kushalkolar
requested changes
Oct 26, 2023
Member
|
seems like the wrong commit got reverted, this is still changing the rest of the codebase |
kushalkolar
requested changes
Oct 27, 2023
Member
kushalkolar
left a comment
There was a problem hiding this comment.
Also regenerate the add graphics mixin
kushalkolar
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#305
Refactored the text graphic to use properties and some more features of
pygfx TextGeometry