Skip to content

Conversation

@mvanderlee
Copy link

Fixes: #14646

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2026

Merging this PR will not alter performance

Summary

✅ 20 untouched benchmarks
⏩ 40 skipped benchmarks1


Comparing mvanderlee:mvanderlee/sentinel-support (5a254e5) with master (f2687dc)

Open in CodSpeed

Footnotes

  1. 40 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mvanderlee mvanderlee force-pushed the mvanderlee/sentinel-support branch from 8dc2adb to dc8e305 Compare January 6, 2026 22:01
@mvanderlee mvanderlee force-pushed the mvanderlee/sentinel-support branch from dc8e305 to a5d28b0 Compare January 6, 2026 22:06
@YuriiMotov YuriiMotov added the feature New feature or request label Jan 6, 2026

try:
# This was added in 4.14.0 (June 2, 2025) We want to be able to support older versions
from typing_extensions import Sentinel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will need to be updated whenever sentinels gets added in the stdlib, to take both variants into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants