Skip to content

fix bug when build core only #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix bug when build core only #292

wants to merge 2 commits into from

Conversation

@waruto210
Copy link

@waruto210 waruto210 commented Jan 23, 2025 •
edited
Loading

close #291

  1. use find_package(cpprestsdk QUIET) instead of find_dependency(cpprestsdk) in config file
  2. add .vscode to .gitignore
  3. do not build Client.cpp if BUILD_ETCD_CORE_ONLY=ON

@waruto210 waruto210 force-pushed the fix/build_core_only branch from 3d44757 to 27d96a2 Compare January 23, 2025 05:23
@waruto210
Copy link
Author

waruto210 commented Jan 23, 2025

@sighingnow PTAL

@Mengna-Li Mengna-Li mentioned this pull request Jan 24, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Find dependency failed if build with BUILD_ETCD_CORE_ONLY=ON

1 participant

@waruto210