chore: Update to use espp IDF components from component registry, also update some deps #108
Conversation
…o update some deps
|
✅Static analysis result - no issues found! ✅ |
ESP-IDF Size Report for 'Esp Box Emu'
FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available. |
There was a problem hiding this comment.
Pull Request Overview
Updates the project to use espp IDF components from the component registry instead of git submodules, and updates some dependencies including ESP-IDF version to 5.5.1.
- Migrated from git submodule to component registry for espp components
- Updated ESP-IDF version from 5.4 to 5.5.1 and TinyUSB library to v2.0+
- Refactored USB MSC initialization to use new TinyUSB API structure
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| main/idf_component.yml | Adds component manifest with espp/monitor dependency |
| components/jpegdec | Updates jpegdec submodule commit hash |
| components/gui/generated/ui.h | Changes LVGL include path from "lvgl/lvgl.h" to "lvgl.h" |
| components/espp | Removes espp git submodule |
| components/box-emu/src/make_color.cpp | Updates LVGL include path |
| components/box-emu/src/box-emu.cpp | Refactors USB MSC initialization for new TinyUSB API |
| components/box-emu/include/box-emu.hpp | Updates TinyUSB includes and adds storage handle member |
| components/box-emu/idf_component.yml | Updates dependencies and IDF version requirements |
| components/box-emu/example/CMakeLists.txt | Removes espp components path from EXTRA_COMPONENT_DIRS |
| components/box-emu/CMakeLists.txt | Adds "lvgl" to component requirements |
| CMakeLists.txt | Comments out espp components path |
| .gitmodules | Removes espp git submodule configuration |
| .github/workflows/static_analysis.yml | Removes hardcoded ESP-IDF version |
| .github/workflows/package_main.yml | Updates to use environment variables and adds size delta analysis |
| .github/workflows/build.yml | Updates ESP-IDF version and adds size delta analysis |
| .github/instructions/ato.instructions.md | Adds new ATO language documentation file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tinyusb_msc_fatfs_config_t config_msc = { | ||
| .base_path = (char*)mount_point, | ||
| .config = fat_mount_config, | ||
| .do_not_format = true, | ||
| .format_flags = 0, | ||
| }; |
There was a problem hiding this comment.
The C-style cast (char*)mount_point should be replaced with a C++ static_cast for better type safety: static_cast<char*>(mount_point).
| // no device_event_handler for tud_mount and tud_unmount callbacks | ||
| tinyusb_config_t tusb_cfg = TINYUSB_DEFAULT_CONFIG(); | ||
| tusb_cfg.task = TINYUSB_TASK_CUSTOM(4096 /*size */, 4 /* priority */, | ||
| 0 /* affinity: 0 - CPU0, 1 - CPU1 ... */); |
There was a problem hiding this comment.
Magic numbers should be defined as named constants. Consider defining constants for task size (4096), priority (4), and CPU affinity (0) to improve code maintainability.
No description provided.