fix: Types to align with older ESLint types #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
reviewed
Feb 20, 2025
Co-authored-by: Francesco Trotta <github@fasttime.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fix the type definitions for
RuleContextto align with older@types/eslinttypes.What changes did you make? (Give an overview)
packages/core/src/types.ts: Added a newRuleFixertype to handle rule fixes more flexibly.packages/core/src/types.ts: Updated thefixandsuggestproperties in theViolationReportBaseinterface to use the newRuleFixertype and allownullorundefinedvalues.New test cases:
packages/core/tests/types/types.test.ts: Added a new test case for thesuggestproperty to ensure it can beundefined.packages/core/tests/types/types.test.ts: Added a new test case to check the handling offixandsuggestproperties when they arenull.Related Issues
Refs eslint/eslint#19441
Is there anything you'd like reviewers to focus on?