Skip to content

Conversation

@luentrix
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

PR #20015 adds a name property to eslint:all and eslint:recommended. However, this will cause issues because these configs are still used in eslintrc, which does not support a name property and will throw an error.

What changes did you make? (Give an overview)

I updated FlatCompat to strip the name property from these configs

Related Issues

Is there anything you'd like reviewers to focus on?

No

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 19, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Oct 19, 2025
@eslintbot eslintbot added this to Triage Oct 19, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 19, 2025
@aladdin-add aladdin-add moved this from Needs Triage to Evaluating in Triage Oct 19, 2025
@aladdin-add
Copy link
Member

thanks for the PR. However, this package is frozen except for critical bug fixes as ESLint moves to a new config system. I don't think the change qualify.

Let's see what other team members think. @eslint/eslint-team

@DMartens
Copy link

The name property is added as in v10 the old config format is being removed.
As such there are no compability issues anymore when adding name.
You can keep using v9 if you want to keep using the old config format.

@fasttime
Copy link
Member

I think the goal of this pull request is to fix the issue with FlatCompat noted in this comment, where eslintrc-style configs fail validation when a name property is added.

FlatCompat is a utility we want to continue supporting beyond the lifetime of eslintrc, even if it's included in this deprecated package, so I think a change here makes sense. The only question is whether the name validation should be relaxed for all configs, as suggested in the original issue, or only for eslint:all and eslint:recommended, which is what this PR currently does. The approach in this PR seems also fine if we don't anticipate new use cases, but I'd like to hear other opinions.

aladdin-add
aladdin-add previously approved these changes Oct 25, 2025
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like another review before merging.

@aladdin-add aladdin-add moved this from Evaluating to Second Review Needed in Triage Oct 25, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 344da49 into eslint:main Oct 29, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working contributor pool

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants