-
-
Notifications
You must be signed in to change notification settings - Fork 48
fix: Remove name property from all and recommended configs #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks for the PR. However, this package is frozen except for critical bug fixes as ESLint moves to a new config system. I don't think the change qualify. Let's see what other team members think. @eslint/eslint-team |
|
The |
|
I think the goal of this pull request is to fix the issue with
|
aladdin-add
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Would like another review before merging.
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
PR #20015 adds a
nameproperty toeslint:allandeslint:recommended. However, this will cause issues because these configs are still used in eslintrc, which does not support anameproperty and will throw an error.What changes did you make? (Give an overview)
I updated
FlatCompatto strip thenameproperty from these configsRelated Issues
Is there anything you'd like reviewers to focus on?
No