fix: Remove name property from all and recommended configs (#200)

luentrix · web-flow · commit 344da491898a · 2025-10-29T15:36:45.000+01:00
* fix: Remove `name` property from eslint:all and eslint:recommended configs

* unconditionally delete `name` from configs
diff --git a/lib/flat-compat.js b/lib/flat-compat.js
@@ -226,15 +226,25 @@ class FlatCompat {
                     throw new TypeError("Missing parameter 'allConfig' in FlatCompat constructor.");
                 }
 
-                return allConfig;
+                // remove name property if it exists
+                const config = { ...allConfig };
+
+                delete config.name;
+
+                return config;
             },
             getEslintRecommendedConfig() {
 
                 if (!recommendedConfig) {
                     throw new TypeError("Missing parameter 'recommendedConfig' in FlatCompat constructor.");
                 }
 
-                return recommendedConfig;
+                // remove name property if it exists
+                const config = { ...recommendedConfig };
+
+                delete config.name;
+
+                return config;
             }
         });
     }
diff --git a/tests/lib/flat-compat.js b/tests/lib/flat-compat.js
@@ -1027,6 +1027,28 @@ describe("FlatCompat", () => {
             }, /Missing parameter 'recommendedConfig'/gu);
         });
 
+        it("should remove name property from eslint:all and eslint:recommended configs", () => {
+            const compatWithNames = new FlatCompat({
+                baseDirectory: getFixturePath("config"),
+                recommendedConfig: {
+                    name: "eslint:recommended",
+                    settings: { "eslint:recommended": true }
+                },
+                allConfig: {
+                    name: "eslint:all",
+                    settings: { "eslint:all": true }
+                }
+            });
+
+            const allResult = compatWithNames.extends("eslint:all");
+            const recommendedResult = compatWithNames.extends("eslint:recommended");
+
+            assert.strictEqual(allResult.length, 1);
+            assert.isTrue(allResult[0].settings["eslint:all"]);
+
+            assert.strictEqual(recommendedResult.length, 1);
+            assert.isTrue(recommendedResult[0].settings["eslint:recommended"]);
+        });
     });
 
     describe("plugins()", () => {
