-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
ci: add v9.x-dev branch
#20382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add v9.x-dev branch
#20382
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
| uses: actions/checkout@v5 | ||
| with: | ||
| repository: eslint/json | ||
| ref: json-v0.14.0 # Tag of the last version that is compatible with ESLint v9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to make these changes because of type incompatibilities with the head version:
https://github.com/eslint/eslint/actions/runs/19986123968/job/57320357289
snitin315
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question.
| branches: [main] | ||
| branches: [main, v9.x-dev] | ||
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: [main] | ||
| branches: [main, v9.x-dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the v8.x-dev branch, this workflow file only triggers on the main branch, but I guess we just forgot to update it?
https://github.com/eslint/eslint/blob/v8.x-dev/.github/workflows/codeql-analysis.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just forgot to update it?
I believe that was the case.
This PR intentionally targets the
v9.x-devbranch.Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Adds
v9.x-devbranch to workflow files in order to trigger CI checks on commits to this branch and PRs that target this branch.What changes did you make? (Give an overview)
Updated workflow files.
Is there anything you'd like reviewers to focus on?