Skip to content

Conversation

@mdjermanovic
Copy link
Member

This PR intentionally targets the v9.x-dev branch.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Adds v9.x-dev branch to workflow files in order to trigger CI checks on commits to this branch and PRs that target this branch.

What changes did you make? (Give an overview)

Updated workflow files.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner December 6, 2025 08:49
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 6, 2025
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Dec 6, 2025
@netlify
Copy link

netlify bot commented Dec 6, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 5de4c4e
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6933f6f719b2ee000805c786

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 6, 2025
uses: actions/checkout@v5
with:
repository: eslint/json
ref: json-v0.14.0 # Tag of the last version that is compatible with ESLint v9
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to make these changes because of type incompatibilities with the head version:

https://github.com/eslint/eslint/actions/runs/19986123968/job/57320357289

@mdjermanovic mdjermanovic added the v9.x Issues/PRs related to the v9.x release line label Dec 6, 2025
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Dec 6, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

Comment on lines -16 to +19
branches: [main]
branches: [main, v9.x-dev]
pull_request:
# The branches below must be a subset of the branches above
branches: [main]
branches: [main, v9.x-dev]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the v8.x-dev branch, this workflow file only triggers on the main branch, but I guess we just forgot to update it?

https://github.com/eslint/eslint/blob/v8.x-dev/.github/workflows/codeql-analysis.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just forgot to update it?

I believe that was the case.

@fasttime fasttime moved this from Triaging to Implementing in Triage Dec 6, 2025
@fasttime fasttime merged commit 4c9858e into v9.x-dev Dec 6, 2025
32 checks passed
@fasttime fasttime deleted the ci-v9.x-dev branch December 6, 2025 12:18
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process github actions v9.x Issues/PRs related to the v9.x release line

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants