Fix error when calling dashboard-previous-section before any section #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place cursor on "Welcome to Emacs!" or just anywhere before the first section, then run `dashboard-previous-section` --- it will error out (at goto-char) complaining that nil is not a number or marker. This is caused by the current version not checking if local variables previous-section-start or current-section-start are non-nil (unlike dashboard-next-section).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place the cursor on "Welcome to Emacs!" or just anywhere before the first section, then run
dashboard-previous-section--- it will error out (atgoto-char) complaining that nil is not a number or marker. This is caused by the current version not checking if local variablesprevious-section-startorcurrent-section-startare non-nil (unlikedashboard-next-section).This PR fixes that by making
dashboard-previous-sectionfall back to jumping to the current position (effectively doing nothing) when bothprevious-section-startandnext-section-startare nil.