Skip best fleet search for dstack offer#3788
Merged
peterschmidt85 merged 2 commits intomasterfrom Apr 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dstack offerwithout--group-byuses the same/runs/get_planpath as normal run planning, but still ran best-fleet selection before overriding the result with the offer-specific collection path.This meant
dstack offerwithout--fleetstill did candidate-fleet selection andfind_optimal_fleet_with_offers(...), then threw that work away and returned global offers.Also updated in this change:
get_job_plans()description to explaindstack offerwithout--group-byvs normal planning_should_select_best_fleet_candidate()naming and description to make the contract clearercommands == [":"]hack to replace it with an explicit request/API signalReproduce
dstack offer --gpu L4.Before this change, the request evaluated candidate fleets and called
find_optimal_fleet_with_offers(...)even though the final result came from thedstack offerwithout--group-bypath.