Skip to content

FIX: Layout in Options: DirHotlist, FilesViews, Icons#860

Open
avmaksimov wants to merge 1 commit intodoublecmd:masterfrom
avmaksimov:options-fix-layout
Open

FIX: Layout in Options: DirHotlist, FilesViews, Icons#860
avmaksimov wants to merge 1 commit intodoublecmd:masterfrom
avmaksimov:options-fix-layout

Conversation

@avmaksimov
Copy link
Copy Markdown
Contributor

Also I suggest to move "Dir Hotlist additional" to "Dir Hotlist". I see space after another options.

You can see solved problems:
https://i.imgur.com/vUWF5Q4.png
https://i.imgur.com/2FOHOZK.png
https://i.imgur.com/IDumq3t.png

P.S. It's very hard and boring)))

Also I suggest to move "Dir Hotlist additional" to "Dir Hotlist". I see space after another options.

You can see solved problems:
https://i.imgur.com/vUWF5Q4.png
https://i.imgur.com/2FOHOZK.png
https://i.imgur.com/IDumq3t.png

P.S. It's very hard and boring)))
@avmaksimov avmaksimov marked this pull request as ready for review March 9, 2023 20:00
@Skif-off
Copy link
Copy Markdown
Contributor

https://i.imgur.com/2FOHOZK.png

You broke the example, try to set yyyy yyyy yyyy yyyy yyyy.mm.dd hh:mm:ss and compare.

P.S. Do visual bugs look the same in different themes? "Some functions to select appropriate path" looks fine for me (I am using Greybird which supports GTK2 applications).

@avmaksimov
Copy link
Copy Markdown
Contributor Author

You broke the example, try to set yyyy yyyy yyyy yyyy yyyy.mm.dd hh:mm:ss and compare.

This incorrect using but I see that all ok either in Windows either in Linux: https://skr.sh/sInqel0n2GG and https://i.imgur.com/R0ZsoBs.png .

So what's the problem? Could add the screenshot please?

@Skif-off
Copy link
Copy Markdown
Contributor

I mean that the "Formatting" block is shifted entirely, but before only "Date and time format" was shifted.
It doesn't look like a problem (in the vast majority of cases, it would be strange to put a long text there.), just noticed.

@avmaksimov
Copy link
Copy Markdown
Contributor Author

I mean that the "Formatting" block is shifted entirely, but before only "Date and time format" was shifted. It doesn't look like a problem (in the vast majority of cases, it would be strange to put a long text there.), just noticed.

Long text is strange too)). But I think it is better than different comboxs widths. As I see DC prefers autowidth but I would set fix size for comboxes and set Align for label with example by left. And also it will look better for high resolution.

But now I just made by analogy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants