-
Notifications
You must be signed in to change notification settings - Fork 728
Implement tiered versioning scheme for branch snapping workflow #8728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update branch snapping workflow for versioning scheme
Implement tiered versioning scheme for branch snapping workflow
Oct 28, 2025
Copilot finished work on behalf of
dibarbet
October 28, 2025 21:28
dibarbet
reviewed
Oct 28, 2025
Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot finished work on behalf of
dibarbet
October 28, 2025 21:48
dibarbet
reviewed
Oct 28, 2025
Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot finished work on behalf of
dibarbet
October 28, 2025 22:08
dibarbet
approved these changes
Oct 28, 2025
JoeRobich
approved these changes
Oct 29, 2025
JoeRobich
reviewed
Oct 29, 2025
JoeRobich
reviewed
Oct 29, 2025
Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot finished work on behalf of
dibarbet
October 29, 2025 18:31
dibarbet
approved these changes
Oct 29, 2025
JoeRobich
approved these changes
Oct 29, 2025
Member
|
@dotnet-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Branch Snapping Workflow for New Versioning Scheme
Completed:
incrementVersiontask to support release candidate flagChanges Made:
Latest Code Review Feedback Addressed:
addChangelogSection()helper function to eliminate duplication between tasksupdateVersionForStableReleasenow automatically adds a changelog entry that references the prerelease version (e.g., "See 2.74.x for full list of changes")Previous Code Review Feedback Addressed:
readVersionJson()andwriteVersionJson()to eliminate duplicationupdateVersionForReleasetoupdateVersionForStableReleasefor claritypeter-evans/create-pull-request@v4action in workflow1. Helper Functions & Tasks (tasks/snapTasks.ts)
getNextReleaseVersion(): Rounds up minor version to next tens (e.g., 2.74 → 2.80)readVersionJson(): Helper to read and parse version.jsonwriteVersionJson(): Helper to write version.json with consistent formattingaddChangelogSection(): Helper to add a new version section to the changelog (with optional additional lines)updateVersionForStableRelease: Gulp task for prerelease → release snaps, now includes automatic changelog update with reference to prereleaseincrementVersion: Enhanced to accept--releaseCandidateflag with clear, simplified logic2. GitHub Workflow (.github/workflows/branch-snap.yml)
releaseCandidateinput parameter for workflow dispatchbump-main-versionjob to use the flag when providedupdate-release-versionjob to usecreate-pull-requestaction3. Documentation (CONTRIBUTING.md)
4. Test Infrastructure
Testing & Validation:
✅ All unit tests pass (492 total: 482 existing + 10 new)
✅ ESLint passes on all modified files
✅ TypeScript compilation successful
✅ YAML syntax validation passes
✅ Manual testing confirms correct behavior:
updateVersionForStableRelease: 2.74 → 2.80 with changelog entry ✓incrementVersion: 2.74 → 2.75 with changelog entry ✓incrementVersion --releaseCandidate=true: 2.74 → 2.81 with changelog entry ✓Console Output Examples:
Updating 2.74 to 2.75Release candidate, using base version of 2.80thenUpdating 2.74 to 2.81Changelog Example for Stable Release:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.