Skip to content

remove default Parser ctor #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

remove default Parser ctor #1998

merged 1 commit into from
Dec 23, 2022

Conversation

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Dec 20, 2022

No description provided.

jozkee
jozkee approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is just to simplify API surface, LGTM.

@adamsitnik adamsitnik merged commit 23a3b3f into dotnet:main Dec 23, 2022
@adamsitnik adamsitnik deleted the parsingVol1 branch December 23, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jozkee jozkee jozkee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamsitnik @jozkee