Ensure that empty TXT records always renders as "" #256
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibauersachs
requested changes
Jul 24, 2022
| return sb.toString(); | ||
| String s = sb.toString(); | ||
| // always return at least an empty quoted String | ||
| return "".equals(s) ? "\"\"" : s; |
Member
There was a problem hiding this comment.
I'd rather do an if (strings.isEmpty()){ return "\"\""; } at the beginning to avoid unnecessary objects (iterator, string builder, string).
Member
Author
There was a problem hiding this comment.
Sure, that looks better. Updating.
ibauersachs
requested changes
Jul 24, 2022
Member
ibauersachs
left a comment
There was a problem hiding this comment.
Oh, and please target this to the release/3.5.x branch.
Instantiating an empty TXT record using Record.fromString() would previously render as a TXT without the empty string. Closes dnsjava#254
6ed0fcf to
43ad780
Compare
Member
Author
|
Updated according to feedback and re-targeted onto release/3.5.x |
ibauersachs
approved these changes
Jul 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiating an empty TXT record using Record.fromString() would
previously render as a TXT without the empty string.
Closes #254