Skip to content

Fix validation of TSIG signed responses #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ibauersachs merged 2 commits into from
Mar 19, 2022
Merged

Fix validation of TSIG signed responses #249

ibauersachs merged 2 commits into from
Mar 19, 2022

Conversation

@ibauersachs
Copy link
Member

@ibauersachs ibauersachs commented Mar 11, 2022

No description provided.

@ibauersachs ibauersachs changed the base branch from master to release/3.5.x March 11, 2022 19:35
@ibauersachs ibauersachs linked an issue Mar 11, 2022 that may be closed by this pull request
DDNS update successful but response from DNS server has invalid TSIG #248
Closed
@ibauersachs ibauersachs added this to the v3.5.1 milestone Mar 11, 2022
@ibauersachs ibauersachs reopened this Mar 11, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

49.2% 49.2% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 43.24324% with 21 lines in your changes missing coverage. Please review.

Project coverage is 64.02%. Comparing base (181aaaf) to head (a0b3470).
Report is 37 commits behind head on release/3.5.x.

Files with missing lines Patch % Lines
src/main/java/org/xbill/DNS/tools/jnamed.java 0.00% 14 Missing ⚠️
src/main/java/org/xbill/DNS/TSIG.java 50.00% 2 Missing and 1 partial ⚠️
src/main/java/org/xbill/DNS/SimpleResolver.java 66.66% 2 Missing ⚠️
src/main/java/org/xbill/DNS/DohResolver.java 0.00% 1 Missing ⚠️
src/main/java/org/xbill/DNS/Message.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##             release/3.5.x     #249      +/-   ##
===================================================
+ Coverage            63.59%   64.02%   +0.42%     
- Complexity            2734     2748      +14     
===================================================
  Files                  178      178              
  Lines                12512    12513       +1     
  Branches              1903     1904       +1     
===================================================
+ Hits                  7957     8011      +54     
+ Misses                4084     4008      -76     
- Partials               471      494      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibauersachs ibauersachs merged commit 17fe79c into release/3.5.x Mar 19, 2022
@ibauersachs ibauersachs deleted the bugfix/tsig-response branch March 19, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.5.1

Development

Successfully merging this pull request may close these issues.

DDNS update successful but response from DNS server has invalid TSIG

3 participants

@ibauersachs @codecov-commenter