Skip to content

Reset existing config before loading it again #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ibauersachs merged 1 commit into from
Oct 26, 2021
Merged

Reset existing config before loading it again #230

ibauersachs merged 1 commit into from
Oct 26, 2021

Conversation

@ibauersachs
Copy link
Member

@ibauersachs ibauersachs commented Oct 24, 2021

Closes #226

@ibauersachs ibauersachs linked an issue Oct 24, 2021 that may be closed by this pull request
Old DNS servers are not cleared out when network changes #226
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #230 (3d6395a) into release/3.4.x (351c935) will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release/3.4.x     #230      +/-   ##
===================================================
+ Coverage            56.00%   56.05%   +0.04%     
- Complexity            2019     2023       +4     
===================================================
  Files                  163      163              
  Lines                10843    10852       +9     
  Branches              1566     1568       +2     
===================================================
+ Hits                  6073     6083      +10     
- Misses                4350     4352       +2     
+ Partials               420      417       -3
Impacted Files Coverage Δ
...bill/DNS/config/AndroidResolverConfigProvider.java 0.00% <0.00%> (ø)
...l/DNS/config/ResolvConfResolverConfigProvider.java 46.15% <0.00%> (-0.91%) ⬇️
...bill/DNS/config/WindowsResolverConfigProvider.java 6.12% <0.00%> (-0.13%) ⬇️
...g/xbill/DNS/config/BaseResolverConfigProvider.java 59.18% <100.00%> (+2.66%) ⬆️
.../DNS/config/JndiContextResolverConfigProvider.java 72.09% <100.00%> (+0.66%) ⬆️
...ill/DNS/config/PropertyResolverConfigProvider.java 88.46% <100.00%> (+0.46%) ⬆️
...xbill/DNS/config/SunJvmResolverConfigProvider.java 90.00% <100.00%> (+0.52%) ⬆️
src/main/java/org/xbill/DNS/DohResolver.java 51.19% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351c935...3d6395a. Read the comment docs.

@ibauersachs ibauersachs requested a review from nresare October 24, 2021 16:57
nresare
nresare approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@nresare nresare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this seems pretty straight forward

@ibauersachs ibauersachs merged commit 2abe743 into release/3.4.x Oct 26, 2021
@ibauersachs ibauersachs deleted the bugfix/clear-config branch October 26, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nresare nresare nresare approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Old DNS servers are not cleared out when network changes

4 participants

@ibauersachs @codecov-commenter @nresare