Skip to content

Conversation

@longchiwen
Copy link
Contributor

Use of internal _pre_setup test method caused broken test suite on newer version of django. This PR uses standard setUp method instead. Was tested on django 4.2. and 5.2.

Because of this issue test for the following PRs are failing:

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@f5fd6fc). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #556   +/-   ##
=========================================
  Coverage          ?   95.78%           
=========================================
  Files             ?       36           
  Lines             ?     2444           
  Branches          ?        0           
=========================================
  Hits              ?     2341           
  Misses            ?      103           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clintonb clintonb merged commit 0cfce42 into django-waffle:master Apr 24, 2025
15 checks passed
@longchiwen longchiwen deleted the fix/django5-tests branch April 24, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants