Skip to content

Conversation

@dancergraham
Copy link
Member

Add missing attributes and methods

@dancergraham dancergraham requested a review from ulgens December 9, 2024 22:25
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".
html_static_path = ['_static']
# html_static_path = ['_static']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for looking at this - this line raises a warning during build because there is nothing in there - I just commented it to make it easy to find again later if we want to add any static assets

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see the warning on line 7 of the Build docs phase of my other PR, which adds tests for pull requests that touch docs

https://github.com/jazzband/django-waffle/actions/runs/12378362580/job/34550046030

@clintonb clintonb merged commit 2dd8fac into django-waffle:master Dec 20, 2024
11 checks passed
@dancergraham dancergraham linked an issue Dec 28, 2024 that may be closed by this pull request
@dancergraham dancergraham deleted the docs-improve-api-docs branch December 28, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve api documentation

2 participants