Skip to content

Conversation

@mrbazzan
Copy link
Contributor

  • add guide on contributing code patch
  • fix minor typos

Description

Fixes #8035

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution! 🎉

As it's your first contribution, be sure to check out the contribution docs.

We invite you to join us on our Discord Server!

Welcome aboard ⛵️!

@mrbazzan mrbazzan changed the title doc: add guide on contributing a code patch docs: Add guide on contributing a code patch Oct 21, 2024
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got just a tiny comment on this.


#. Install its dependencies::

cd django-cms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd django-cms

Not necessary if virtual environment is in the project directory.

@fsbraun fsbraun requested a review from a team October 22, 2024 14:13
* add guide on contributing code patch
* fix minor typos
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @mrbazzan !

@fsbraun fsbraun merged commit 2ca2ccd into django-cms:develop-4 Oct 24, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Notes and minor errors in the doc

3 participants