Fixes case when font is different from attributed font. #44
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
your unit tests didn't catch it because you needed to check against the |
Owner
|
Hmm, how about just not updating the font if there is if (self.needsUpdateFont) {
- self.placeholderLabel.font = self.font;
+ if (self.attributedPlaceholer != nil) {
+ self.placeholderLabel.font = self.font;
+ }
self.needsUpdateFont = NO;
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
There is a bug where a font attributed is ignored (when using attributedPlaceholder). The UITextView's font is used instead.
Fix
Checks to see if there is font set on the attributed placeholder. If so we use that. If not we fall back and use the UITextView's font instead.