-
Notifications
You must be signed in to change notification settings - Fork 526
[Feature] Optionally keep Only Longest Video Option for Sliding Window Generation #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…with InfiniteTalk
|
Wait, it didn't already work that way? |
Recent version of framepack actually have that option now. |
09ba52b to
91f318c
Compare
- Implement LCMScheduler with RectifiedFlow (LTX) dynamics - Combine Latent Consistency Model with rectified flow scheduling - Optimize for 2-8 step ultra-fast inference with Lightning LoRAs - Add proper flow matching dynamics with shift parameter support - Update UI to show 'lcm + ltx' option in sampler dropdown
Add LCM + LTX Sampler
|
Shouldnt this feature be a general switch in the Config Tab rather than a per model switch ? |
Yea that makes more sense imo |
d0ce9d2 to
91f318c
Compare
Agreed, should it go in the "General" config tab? |
91f318c to
f6f4dcd
Compare
…g tab - Added sliding_window_keep_only_longest dropdown in General config tab - Setting is now stored in server_config and persists across sessions - Removed per-model checkboxes from sliding window tabs - Access setting directly from server_config in generate_video function - Added cleanup status to sliding window info message - Default value: False (disabled) for backward compatibility
- Created shared/utils/sliding_window_cleanup.py for cleanup functions - Moved cleanup_previous_video() function to utility module - Added should_cleanup_video() helper function - Added get_cleanup_status_text() for status messages - Updated wgp.py to use the new utility functions - Improves code organization and reusability
- Updated cleanup_previous_video() to handle condition checks internally - Removed inline condition checks from wgp.py - Cleaner separation: wgp.py only has minimal GUI glue code - All business logic now contained in utility module
95fca0d to
b1057b7
Compare
|
refactor done. moved the config location and moved the application logic to another file. ready to merge |
|
thx, but I think this could be made much simpler: |
All code and this PR description was generated by AI.
🚀 Overview
This PR introduces a new "Keep only longest video" feature for sliding window generation.
✨ New Features
Keep Only Longest Video Option
Enhanced Sliding Window Pipeline
sliding_window_keep_only_longestparameter ingenerate_videofunction🔧 Technical Implementation
Core Changes
File System Integration
🎯 Use Cases
Clean Workflows
📋 Technical Details
New Parameters
sliding_window_keep_only_longest- Boolean flag for enabling cleanup modeFalse(maintains backward compatibility)File Management Logic
Error Handling
🔗 Files Changed
wgp.py- Main implementation of keep longest feature, UI fixes, and settings fix.gitignore- Updated patterns for better repository management