Skip to content

Add a config for pre-commit hook; Makefile targets for formatting #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a config for pre-commit hook; Makefile targets for formatting #220

wants to merge 1 commit into from

Conversation

@alexott
Copy link
Collaborator

@alexott alexott commented Sep 29, 2025

No description provided.

@alexott alexott requested review from a team as code owners September 29, 2025 11:07
@alexott alexott requested a review from Divyansh-db September 29, 2025 11:07
@VictorColome
Copy link
Contributor

VictorColome commented Oct 2, 2025 •
edited
Loading

@alexott considering you are adding pre-commit, why not adding also checkov for security validation?

- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: v1.100.1 # Get the latest from: https://github.com/antonbabenko/pre-commit-terraform/releases
  hooks:
    - id: terraform_fmt
    - id: terraform_checkov
      args:
        - --args=--quiet
        - --args=--check MEDIUM,HIGH,CRITICAL

I usually add the args MEDIUM,HIGH,CRITICAL to hide the LOW errors which can be quite noisy.

Just as a recommendation! :)

@alexott
Copy link
Collaborator Author

alexott commented Oct 2, 2025

@VictorColome one thing a time ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Divyansh-db Divyansh-db Awaiting requested review from Divyansh-db Divyansh-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexott @VictorColome