Skip to content

Examples menu document #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Examples menu document #880

wants to merge 1 commit into from

Conversation

@janat08
Copy link

@janat08 janat08 commented Mar 24, 2019 •
edited
Loading

###--------------------------------------------------------###
docs(examples): examples menu document

Surmised various example applications, and described principles demonstrated in simple examples.

ISSUES CLOSED: #480
###--------------------------------------------------------###

@staltz
Copy link
Member

staltz commented Mar 25, 2019

Hi @janat08 :)
Thanks for submitting this PR, we appreciate the desire to help. Before merging this PR could you notice and fix typos in the readme text, and then rewrite the commit message so that it conforms to the commit convention? (You probably saw a note about this in the PR template)

staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
staltz
staltz reviewed Mar 25, 2019
View reviewed changes
@janat08 janat08 force-pushed the documentExamples branch 2 times, most recently from 13d717a to c1af58a Compare March 25, 2019 18:55
@janat08
Copy link
Author

janat08 commented Mar 25, 2019

I was hoping to get the bounty from issuehunt, even if the issue was meant for commenting the code.

staltz
staltz reviewed Mar 27, 2019
View reviewed changes
jopek
jopek reviewed Apr 23, 2019
View reviewed changes
Copy link

@jopek jopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@staltz
Copy link
Member

staltz commented Apr 26, 2019

I guess I'm waiting for this step before merging:

and then rewrite the commit message so that it conforms to the commit convention? (You probably saw a note about this in the PR template)

:)

@janat08
Examples menu document
13d35ef 
###--------------------------------------------------------###
docs(examples): examples menu document

Surmised various example applications, and described principles demonstrated in simple examples.

ISSUES CLOSED: cyclejs#480
###--------------------------------------------------------###
@janat08
Copy link
Author

janat08 commented Apr 26, 2019

Thanks for clarification. I use gitkraken gui app, so neither the pull or commit templates showed up.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staltz staltz staltz left review comments

+1 more reviewer

@jopek jopek jopek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Examples documentation

3 participants

@janat08 @staltz @jopek