Fix command visibility in the VS Code Command Palette #692
+69
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move "when" clauses from command definitions to menus.commandPalette section. This fixes commands like Logout and Create Workspace appearing in the palette before the user is authenticated.
ae0e56a to
24f644b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Commands with authentication requirements (like Logout, Create Workspace, Refresh Workspaces) were appearing in the Command Palette even when the user wasn't logged in. This happened because
whenclauses placed directly on command definitions do not affect the Command Palette visibility.Solution
whenclauses from command definitions tomenus.commandPalettewhere they actually control visibilitycategory: "Coder"instead of prefixing titles with "Coder:"Additional Changes (Sonarlint fixes)
node:fs/promisesimport protocol for consistencylocaleCompare()to avoid locale-dependent behavior