chore: upgrade to coder/websocket 1.8.12 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is a prereq to moving coder/coder over to coder/websocket, so that we don't build and include two separate websocket libraries. |
deansheather
approved these changes
Dec 3, 2024
Author
Member
|
@spikecurtis we still reference wsconn in coder/coder https://github.com/coder/coder/blob/main/tailnet/derp.go#L13 |
Author
Not anymore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates to coder/websocket from nhooyr/websocket and upgrades to v1.8.12.
Also retires and removes
wsconnwhich was a fork ofwebsocket's implementation ofNetConnto work around a bug that has been fixed.