fix: make make test runnable again
#21251
Open
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Contributor
DevelopmentCats
left a comment
There was a problem hiding this comment.
🔍 Code Review
Reviewed memory optimization changes across test infrastructure.
Found 1 issue (1 important).
AI review via Coder Tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All credit for this fix goes to Opus 4.5 ❤️
I identified a problem this morning; we thought the reason for tests were using up to 25GiB of RAM due to excessive postgres databases being created after we moved away from dbmem. As it turns out, about half of the in-use heap is caused by Wireguard device buffers.
coder/wireguard-go#4 is a vibed solution to this problem whereby the buffers are tuned way down when a build tag is used. Disclaimer: I have no idea what impact this has as I haven't looked into this very carefully yet, BUT the tests all pass so 🤷.
Uncached:
DONE 13293 tests, 51 skipped in 162.041sand uses about 4GiB of RAMCached:
DONE 13293 tests, 51 skipped in 7.712sand uses about 1GiB of RAMThe RAM usage observations were purely just eyeballing using
topand comparing against the baseline; confounding factors abound, but it's much better than it was at least. Needs validation.