-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: output cached tokens for <RequestLogsRow />
#20974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dannykopping
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, needs some tests please.
Someone from the FE squad will have to give the final review, though.
site/src/pages/AIBridgePage/RequestLogsPage/RequestLogsRow/RequestLogsRow.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/AIBridgePage/RequestLogsPage/RequestLogsRow/RequestLogsRow.tsx
Show resolved
Hide resolved
<RequestLogsRow /> cached tokens output<RequestLogsRow />
site/src/pages/AIBridgePage/RequestLogsPage/RequestLogsRow/RequestLogsRow.tsx
Show resolved
Hide resolved
site/src/pages/AIBridgePage/RequestLogsPage/RequestLogsRow/RequestLogsRow.tsx
Outdated
Show resolved
Hide resolved
|
@jakehwll you mentioned this is temporary but it still may be useful to a test to confirm the logic |
dannykopping
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Thanks @jakehwll
Closes #21217
This pull-request traverses the
token_usages.metadata[...]fields and merges them into a single consumable object so that we're able discern information about the metadata within the token usages at a glance. Its not the be-all end-all implementation of this feature but its a stepping stone in order to render more useful data to the frontend.These are currently mergable because they only contain
numberbased fields. When it encounters something within the object that can't be merged (minus empty objects{}) it will simply return them as an array.Preview
Logic breakdown