Fix regression for archived sections #70231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where archived sections were incorrectly displayed on student dashboards due to the missing hidden property in the summarize_for_participant method. The fix restores the hidden property to the returned hash, updates existing test data to include this property, and adds a new unit test to prevent future regressions.
Key Changes
- Restored the
hiddenproperty to thesummarize_for_participantmethod in the Section model - Updated all existing test fixtures to include the
hidden: falseproperty for consistency - Added new test case and fixture data to verify that archived sections (with
hidden: true) are properly filtered from student views
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dashboard/app/models/sections/section.rb | Adds the hidden property back to the hash returned by summarize_for_participant |
| apps/test/unit/templates/studioHomepages/homepagesTestData.js | Updates test fixtures to include the hidden: false property for all non-archived sections |
| apps/test/unit/templates/studioHomepages/fakeSectionUtils.js | Adds hidden: false to existing section fixtures and introduces a new archivedSections fixture |
| apps/test/unit/templates/studioHomepages/ParticipantSectionsTest.jsx | Adds new test case to verify archived sections are not displayed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
367e4c2 to
a9c388e
Compare
- Fix regression where archived sections are showing up in student
dashboard
- Add hidden property back to section data passed to the frontend
- Re-add property in existing tests
- Add new unit test to cover functionality
Signed-off-by: Nick Lathe <nick.lathe@code.org>
52e1cb3 to
1302c90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in 66957 that removed the
hiddenproperty from being included in the return hash of the newsummarize_for_participantmethod. That property is eventually evaluated in the ParticipantSections component. This resulted in sections archived by teachers still showing up in student dashboards, in the Classroom Section table.This PR addresses the regression with the following:
hiddenproperty to the hash returned bysummarize_for_participanthiddenproperty to existing testsScreenshots
Teacher archives section
Student view without the hidden property, archived section still included
Student view with hidden property added, archived section no longer included
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: