-
Notifications
You must be signed in to change notification settings - Fork 524
DTL (Test > Levelbuilder): 2bdac0da #70211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-eval-info Set up Lesson Details widget for Student Snapshot
* bug fix * unit test updates * unit test fix
* Remove teacher-notifications experiment flag after release * Fix tests
* Remove deprecated K-5 courses (course1-4, 20-hour) from codebase This commit removes references to the deprecated curricula: course1, course2, course3, course4, and 20-hour (also known as "accelerated"). Changes include: - Remove course constants and categories from ScriptConstants - Remove course recommendation mappings for deprecated courses - Remove certificate logic for 20-hour/accelerated courses - Remove course block helpers for deprecated courses - Remove deprecated unit helper methods (course1_unit, twenty_hour_unit) - Remove legacy course validation logic - Remove deprecated course cards from certificate flow - Remove legacy course components from CourseBlocks UI - Simplify CourseBlocksIntl to always show modern courses Note: Config files, i18n files, and deprecated_course view remain for backward compatibility until final removal in September 2025. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Fix tests for deprecated K-5 course removal Update tests to remove references to deprecated courses: - Remove course1-4 and accelerated mappings from csf_next_course_recommendation test - Remove course1/course2 banner image assertions - Remove course4 from tracking pixel and HOC finish URL tests - Remove entire test for 20-hour script routing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Remove csf_international? method and usages The csf_international category was removed as it only contained deprecated courses (course1-4). This removes: - csf_international? method definition - has_banner? check for csf_international courses - View conditional for csf_international courses 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Replace twenty_hour_unit with hoc_2014_unit in test Replace remaining references to removed twenty_hour_unit method with hoc_2014_unit in controller tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Remove deprecated courses from GraduateToNextLevel test Removed course2, course3, and course4 from the test since these courses were deprecated and their cards were removed from the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Replace remaining twenty_hour_unit references with hoc_2014_unit Fixed remaining references to the deprecated twenty_hour_unit method: - Updated header fallback script - Updated API controller fallback - Updated test references in script_level_test and api_controller_test 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Update script_level_test to use dynamically created unit Changed test to create a unit with known structure instead of relying on hoc_2014_unit, which has a different structure than the deprecated twenty_hour_unit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Update certificate tests to remove deprecated course references - Removed tests for 20-hour and accelerated courses - Removed tests for course1-4 - Updated tests to use coursea-2025 as example CSF course - Updated setup to create coursea-2025 instead of deprecated courses - All tests passing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Fix syntax error in scripts/show.html.haml Removed empty if block that was causing 500 errors when viewing course unit overview pages. Also updated db_query_test to reflect correct query count after fixing the view syntax error. * Add back deprecated course constants for deprecated_course view These constants (COURSE1_NAME, COURSE2_NAME, COURSE3_NAME, COURSE4_NAME, TWENTY_HOUR_NAME) are still needed by the deprecated_course.html.haml view to display appropriate messages when users visit deprecated courses. Added them back as standalone constants with a comment explaining they're kept for the deprecated course page rendering. * Add test for deprecated course page rendering Tests that when a course is marked as deprecated, the scripts controller renders the deprecated_course error page with the correct curriculum name. * Clean up a couple more tests * Remove no longer needed test --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
* use Google Blockly for unit tests * revert StudioAppTest * Update StudioAppTest.js * fallback for unloaded translations * try patching keycodes * Revert "try patching keycodes" This reverts commit bfd59c2. * restart ci * do not rely on jQuery UI * no jQuery * no jQuery for StudioAppTest * defensive check * match component change * Update cdoFieldBitmap.ts * use import * Update webpackKarma.config.js * only register stuff once * more translation chaining * various updates * remove 'counts all other blocks' StudioApp.loadBlocks is no longer additive * more chaining * fix turtle tests * use correct generator * await convertXmlToBlockly results * await convertXmlToBlockly results * update block count map after loading blocks to workspace
* Update title for standalone lab2 projects * update title on rename * clean up * always use false for subprojects * update other conditional
…70175) * use Google Blockly for unit tests * revert StudioAppTest * Update StudioAppTest.js * fallback for unloaded translations * try patching keycodes * Revert "try patching keycodes" This reverts commit bfd59c2. * restart ci * do not rely on jQuery UI * no jQuery * no jQuery for StudioAppTest * defensive check * match component change * Update cdoFieldBitmap.ts * use import * Update webpackKarma.config.js * only register stuff once * more translation chaining * various updates * remove 'counts all other blocks' StudioApp.loadBlocks is no longer additive * more chaining * fix turtle tests * use correct generator * await convertXmlToBlockly results * await convertXmlToBlockly results * update block count map after loading blocks to workspace * remove blocklyVersion=cdo url param option * remove cdo blockly 🎉 * remove redundant test util
DTS (Levelbuilder > Staging) [robo-dts]
* add artist, bounce, flappy and minecraft levels to allthethings * move initial_page_views_csf.feature onto allthethings * stop seeding course2 in test * use allthethings levels to check finish button on blockly levels * use bounce free play level * update minecraft finish tests * remove artist unit from ui tests * fix Minecraft Adventurer free play url * stop seeded remaining courses 1-4 in ui tests * stop seeding minecraft course in ui tests * trigger cache staging build, against current branch, to temp location * sign drone * Revert "trigger cache staging build, against current branch, to temp location" This reverts commit 5bf1e6f. * run drone tests against temp cached staging build * seed artist again * Revert "run drone tests against temp cached staging build" This reverts commit 0f354ac. * trigger cache staging build, against current branch, to temp location * Revert "trigger cache staging build, against current branch, to temp location" This reverts commit 82b7b22. * run drone tests against temp cached staging build * Revert "run drone tests against temp cached staging build" This reverts commit cd38756. * sign drone * Revert "add artist, bounce, flappy and minecraft levels to allthethings" This reverts commit 007f277.
* add rails validation to prevent unlaunching a stable course * fix UnitTest * temp skip known flaky tests due to frequent sequel timeouts * Revert "temp skip known flaky tests due to frequent sequel timeouts" This reverts commit 23bf748.
DTS (Levelbuilder > Staging) [robo-dts]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.