[CodeReview] Automatically turns on Sharing when students are assigned to Code Review Groups #70178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR automatically enables sharing for students when they are assigned to code review groups, addressing a bug where students could be in a code review group but unable to use the feature due to disabled sharing settings.
- Modifies
reset_code_review_groupsto track and enable sharing for assigned students - Adds a new helper method
enable_sharing_for_followersto update sharing settings - Includes test coverage verifying sharing is enabled for assigned students but not for unassigned ones
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dashboard/app/models/sections/section.rb | Adds logic to track assigned follower IDs and enable sharing for students in code review groups |
| dashboard/test/models/sections/section_test.rb | Adds test case to verify sharing is automatically enabled for students assigned to code review groups |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
molly-moen
approved these changes
Jan 5, 2026
fisher-alice
approved these changes
Jan 5, 2026
Contributor
fisher-alice
left a comment
There was a problem hiding this comment.
Nice! Just left a suggestion as discussed in Slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically turns on sharing for students assigned code review groups. It fixes a bug where a student could be in a code review group but unable to utilize the feature because sharing is disabled. We believe that the assignment implicitly approves sharing.
Before:
Screen.Recording.2026-01-05.at.12.03.45.PM.mov
After:
Screen.Recording.2026-01-05.at.11.57.21.AM.mov
This is the approach we believe (see slack thread) to be the lowest lift for engineering, design, and teachers.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: