Skip to content

fix(ai-chat): guard against nil dimension values #70093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drizco merged 2 commits into from
Dec 18, 2025
Merged

fix(ai-chat): guard against nil dimension values #70093

drizco merged 2 commits into from
Dec 18, 2025

Conversation

@drizco
Copy link
Contributor

@drizco drizco commented Dec 17, 2025 •
edited
Loading

prevents cloudwatch metrics call if CDO.rack_env is nil, which we think is possibly causing this honeybadger error

also fixes api response parsing to check for output_tokens rather than completion_tokens

Links

  • Jira:

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Creation Checklist:

  • Tests provide adequate coverage
  • Privacy impacts have been documented
  • Security impacts have been documented
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Follow-up work items (including potential tech debt) are tracked and linked

@drizco drizco marked this pull request as ready for review December 17, 2025 23:25
Hamms
Hamms approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@drizco drizco merged commit 414dc5d into staging Dec 18, 2025
6 checks passed
@drizco drizco deleted the ryan/ai-chat/fix/guard-against-nil-dimension-values branch December 18, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hamms Hamms Hamms approved these changes

@Erin007 Erin007 Awaiting requested review from Erin007

@cnbrenci cnbrenci Awaiting requested review from cnbrenci

@edcodedotorg edcodedotorg Awaiting requested review from edcodedotorg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drizco @Hamms