Skip to content

Conversation

@molly-moen
Copy link
Contributor

@molly-moen molly-moen commented Dec 17, 2025

This takes the change added in Droplet prs 231 and 233 and applies them to our repo. See the PRs for details. The first fixes a for loop parsing bug, and the second fixes a null error.

To apply the changes here, I built the new droplet files using DROPLET_LANGUAGE=javascript grunt dist in the droplet repo, then copied the resulting files from dist to the droplet folder.

I confirmed locally that app lab and game lab still work as expected. I've been unable to repro the actual null exception, but the for loop parsing now works!

PR Creation Checklist:

  • Tests provide adequate coverage
  • Privacy impacts have been documented
  • Security impacts have been documented
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen changed the title Droplet: fix common null error Droplet: get latest version Dec 17, 2025
@molly-moen molly-moen changed the title Droplet: get latest version Droplet: use latest version Dec 17, 2025
@molly-moen molly-moen marked this pull request as ready for review December 17, 2025 21:41
@molly-moen molly-moen requested review from a team and fisher-alice December 17, 2025 21:41
Copy link
Contributor

@fisher-alice fisher-alice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@molly-moen molly-moen merged commit c826336 into staging Dec 18, 2025
6 checks passed
@molly-moen molly-moen deleted the molly/droplet-fix-null-error branch December 18, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants