-
Notifications
You must be signed in to change notification settings - Fork 524
move needed pegasus files out of sites.v3 #70066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
commented
Dec 17, 2025
|
|
||
| # used by pegasus-specific dcdo_mocking.feature UI test | ||
| # TODO: remove once we no longer use DCDO flags in pegasus | ||
| pegasus/sites.v3/code.org/public/test_dcdo.haml |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- removed from the repo in CMS-953: Move DCDO mocking test endpoint to Dashboard #67499
|
|
||
| # placeholder image used by pegasus hoc and poste routes | ||
| # TODO: use existing dashboard/app/assets/images/1x1.png instead | ||
| pegasus/sites.v3/code.org/public/images/1x1.png |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- removed from the repo in CMS-745: Remove Pegasus HoC API #69097
artem-vavilov
approved these changes
Dec 17, 2025
Member
artem-vavilov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 🙌🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to move any files we need out of pegasus/sites.v3, for two reasons:
no-pegasus-contentfile in the interim. specifically, it's hard to keep git LFS from pulling those pegasus LFS files down into the .git directory when there is a complicated pattern inno-pegasus-contentDone in this PR:
no-pegasus-contentwhich have already been removed from the repoTesting story
[skip pegasus content]and all unit testsFollow-up work
address remaining TODOs in
no-pegasus-contentfile