Skip to content

Conversation

@fisher-alice
Copy link
Contributor

@fisher-alice fisher-alice commented Dec 16, 2025

This PR shows the browser warning 'Reload site? Changes you made may not be saved' when a user attempts to reload browser when in AI Tutor version view, i.e. when the accept-reject flow is triggered, and the user is prompted to either accept or reject the model's updates.

After update

Screen.Recording.2025-12-16.at.4.19.34.PM.mov

Warning!!

We have entered Pixel Lock for Hour of AI! All merges to the staging branch from Dec 2 through Dec 12 must go through live change review and be deemed critical for supporting the Hour of AI. External contributions will not be accepted at this time.

For non-critical changes, please change your base to staging-next and delete this warning. We will merge staging-next into staging on Dec 15, 2025.

Links

Testing story

Tested locally in weblab2 levels with weblab2-accept-reject flag on.

Deployment strategy

Follow-up work

I noticed that the 'Continue' button is still enabled when the AI tutor's response is pending. I think we should probably disabled the 'Continue' button when waiting for the model response.

It is disabled when in AI tutor version view.

Privacy

Security

Caching

PR Creation Checklist:

  • Tests provide adequate coverage
  • Privacy impacts have been documented
  • Security impacts have been documented
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice fisher-alice changed the title Showwarning when in AI Tutor version and attempting to reload browser Show warning when in AI Tutor version and attempting to reload browser Dec 16, 2025
@fisher-alice fisher-alice marked this pull request as ready for review December 16, 2025 22:34
@fisher-alice fisher-alice requested a review from a team December 16, 2025 22:38
Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🐱 🐶

@fisher-alice fisher-alice merged commit d1ab6d6 into staging Dec 17, 2025
6 checks passed
@fisher-alice fisher-alice deleted the alice/warn-on-reload branch December 17, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants