-
Notifications
You must be signed in to change notification settings - Fork 524
Update aws-sdk-core Gem to Latest Version (3.239)
#69706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also need to update our own `aws-google` gem to pick up code-dot-org/aws-google#13 Part of our ongoing investigation into the `SlowAWSResponse` errors we've been getting; we don't think it's likely that updating this gem will resolve those issues, but we would like to rule that out. Always nice to bring an old dependency up to date, anyway.
snickell
approved these changes
Nov 21, 2025
cat5inthecradle
approved these changes
Dec 1, 2025
Contributor
cat5inthecradle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I uninstalled all local versions of aws-google from my machine, then ran bundle install on this branch and tested "bin/aws_access" successfully.
Contributor
|
Should we propose merging this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of our ongoing investigation into the
SlowAWSResponseerrors we've been getting; we don't think it's likely that updating this gem will resolve those issues, but we would like to rule that out. Always nice to bring an old dependency up to date, anyway.Some details:
We also need to update our own
aws-googlegem to pick up Loosenaws-sdk-coreRequirement aws-google#13We specifically target
3.239.2to pick up the fix added in that version; otherwise, we get:We also need to update
aws-sdk-s3to pick up support for new integrity checking capabilities; otherwise, we get:Testing story
Relying on existing CI/CD tests to verify that this change does not affect any existing functionality.