Skip to content

Conversation

@Hamms
Copy link
Contributor

@Hamms Hamms commented Nov 20, 2025

Part of our ongoing investigation into the SlowAWSResponse errors we've been getting; we don't think it's likely that updating this gem will resolve those issues, but we would like to rule that out. Always nice to bring an old dependency up to date, anyway.

Some details:

  • We also need to update our own aws-google gem to pick up Loosen aws-sdk-core Requirement aws-google#13

  • We specifically target 3.239.2 to pick up the fix added in that version; otherwise, we get:

    /lib/ruby/gems/3.1.0/gems/aws-sdk-core-3.239.0/lib/aws-sdk-core/credential_provider_chain.rb:176:in `login_credentials': undefined method `region' for nil:NilClass (NoMethodError)
    
       Aws.shared_config.login_credentials_from_config(profile: profile_name, region: options[:config].region)
    
  • We also need to update aws-sdk-s3 to pick up support for new integrity checking capabilities; otherwise, we get:

    Minitest::UnexpectedError:         NoMethodError: undefined method `[]' for nil:NilClass                                                                            
                                                                                                                                                                     
                      !context[:http_checksum][:request_algorithm] && # skip in favor of flexible checksum                                                           
                                              ^^^^^^^^^^^^^^^^^^^^                                                                                                   
             /home/elijah/.rbenv/versions/3.1.7/lib/ruby/gems/3.1.0/gems/aws-sdk-core-3.239.2/lib/aws-sdk-core/plugins/http_checksum.rb:15:in `call'                 
             /home/elijah/.rbenv/versions/3.1.7/lib/ruby/gems/3.1.0/gems/aws-sdk-core-3.239.2/lib/aws-sdk-core/plugins/endpoint_pattern.rb:45:in `call'              
             /home/elijah/.rbenv/versions/3.1.7/lib/ruby/gems/3.1.0/gems/aws-sdk-s3-1.112.0/lib/aws-sdk-s3/plugins/accelerate.rb:67:in `call'                        
             /home/elijah/.rbenv/versions/3.1.7/lib/ruby/gems/3.1.0/gems/aws-sdk-core-3.239.2/lib/aws-sdk-core/rest/content_type_handler.rb:27:in `call'             
             /home/elijah/.rbenv/versions/3.1.7/lib/ruby/gems/3.1.0/gems/aws-sdk-s3-1.112.0/lib/aws-sdk-s3/plugins/bucket_dns.rb:35:in `call'                        
             /home/elijah/.rbenv/versions/3.1.7/lib/ruby/gems/3.1.0/gems/aws-sdk-s3-1.112.0/lib/aws-sdk-s3/plugins/dualstack.rb:41:in `call'                         
             /home/elijah/projects/work/code-dot-org/lib/cdo/aws/s3.rb:20:in `call'  
    

Testing story

Relying on existing CI/CD tests to verify that this change does not affect any existing functionality.

We also need to update our own `aws-google` gem to pick up code-dot-org/aws-google#13

Part of our ongoing investigation into the `SlowAWSResponse` errors
we've been getting; we don't think it's likely that updating this gem will resolve
those issues, but we would like to rule that out. Always nice to bring
an old dependency up to date, anyway.
@Hamms Hamms marked this pull request as ready for review November 20, 2025 22:09
@Hamms Hamms requested review from a team and snickell November 20, 2025 22:09
@Hamms Hamms added bug-fix dependencies Pull requests that update a dependency file labels Nov 20, 2025
@Hamms Hamms marked this pull request as draft November 21, 2025 00:26
@Hamms Hamms changed the base branch from staging to staging-next December 1, 2025 21:21
@Hamms Hamms marked this pull request as ready for review December 1, 2025 23:05
Copy link
Contributor

@cat5inthecradle cat5inthecradle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I uninstalled all local versions of aws-google from my machine, then ran bundle install on this branch and tested "bin/aws_access" successfully.

@Hamms Hamms merged commit f8bc43f into staging-next Dec 1, 2025
3 checks passed
@Hamms Hamms deleted the elijah/aws-sdk-core-3.239 branch December 1, 2025 23:19
@sureshc
Copy link
Contributor

sureshc commented Dec 2, 2025

Should we propose merging this into staging for production release before the event?

Hamms added a commit that referenced this pull request Dec 16, 2025
Hamms added a commit that referenced this pull request Dec 16, 2025
Hamms added a commit that referenced this pull request Dec 18, 2025
Hamms added a commit that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants