Skip to content

Don't Load Spring on Chef-managed Deployment Servers #69484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hamms merged 4 commits into from
Dec 18, 2025
Merged

Don't Load Spring on Chef-managed Deployment Servers #69484

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a57ca0c
disable spring on managed servers
Hamms Nov 11, 2025
07d4bb5
update bin/spring with latest results from running 'spring binstub'
Hamms Nov 11, 2025
5c41758
Revert "disable spring on managed servers"
Hamms Nov 11, 2025
392cba4
skip loading spring entirely when running in deployment mode
Hamms Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions dashboard/bin/spring
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,22 @@
#!/usr/bin/env ruby

# This file loads spring without using Bundler, in order to be fast.
# This file loads Spring without using Bundler, in order to be fast.
# It gets overwritten when you run the `spring binstub` command.

unless defined?(Spring)
require 'rubygems'
require 'bundler'

if (match = Bundler.default_lockfile.read.match(/^GEM$.*?^ (?: )*spring \((.*?)\)$.*?^$/m))
Gem.paths = {'GEM_PATH' => [Bundler.bundle_path.to_s, *Gem.path].uniq.join(Gem.path_separator)}
gem 'spring', match[1]
require 'spring/binstub'
# Spring breaks when Bundler is running in deployment mode (ie, on the
# managed test server), but fortunately it also doesn't offer any benefits to
# us on our deployed servers so we can safely skip it in that situation.
unless Bundler.settings[:deployment]
lockfile = Bundler::LockfileParser.new(Bundler.default_lockfile.read)
spring = lockfile.specs.detect {|spec| spec.name == 'spring'}
if spring
Gem.use_paths Gem.dir, Bundler.bundle_path.to_s, *Gem.path
gem 'spring', spring.version
require 'spring/binstub'
end
end
end