userAgent Bug #281
Merged
userAgent Bug #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you use it for Node.js the API breaks when you define userAgent globally
Contributor
|
Hey @echatzief - What bug does this PR fix? |
Contributor
Author
The module is used at the strapi-provider-upload-cloudinary and the navigator is globally defined. Thus, using the library with node.js the navigator breaks (because it's not defined) and throws error to the above plugin. So, you must define the userAgent inside each function not globally. |
Contributor
|
Thanks, sounds like the right approach. We'd like to avoid this code duplication though, can you please move the navigator line to a function? |
Added a function that returns the navigator
Contributor
|
Almost done here, please move it to the top of the file and we're good to merge. |
patrick-tolosa
approved these changes
Jan 2, 2022
ghost
suggested changes
Jan 2, 2022
ghost
approved these changes
Jan 3, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
What does this PR address?
Are tests included?
Reviewer, Please Note: