Expand test for normalize_expression with more complex instances of reserved names
#209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-tolosa
approved these changes
Jan 20, 2021
Contributor
|
@maoznir feel free to merge this once you review |
ghost
approved these changes
Feb 16, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
In previous versions of the JavaScript SDK some variables would be incorrectly normalized if their name contained a reserved keyword (e.g.,
$myheight_100would become$myh_100even though it shouldn't be normalized). This was fixed in the SDK and so is now also fixed in the React SDK.This PR adds a test to verify that it indeed works/
What does this PR address?
Are tests included?
Checklist: