Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 12, 2020

Brief Summary of Changes

By reloading the video on props change we make it easier for users, because they do not need to pass a unique key to rerender on props change.

What does this PR address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are tests included?

  • Yes
  • No

Reviewer, please note:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all of the tests pass.

@ghost ghost requested a review from strausr November 12, 2020 09:48
@ghost ghost changed the title Add unique key to video element Reload video on props change Nov 12, 2020
@ghost ghost merged commit 3ab70fa into master Nov 12, 2020
@ghost ghost deleted the feature/rerender-video branch November 12, 2020 14:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants